From 3cea4eb14f66cdc90bc08361a6d70a155b9333b2 Mon Sep 17 00:00:00 2001
From: mrfaptastic <12006953+mrfaptastic@users.noreply.github.com>
Date: Sun, 10 Jan 2021 17:32:24 +0000
Subject: [PATCH] Update examples

Remove #DEFINE MATRIX_WIDTH and #DEFINE MATRIX_HEIGHT from examples as this does NOT work.

Arduino compiles do not respect #defines in the .ino file within the library.
---
 examples/AuroraDemo/AuroraDemo.ino                        | 5 +++--
 .../ChainedPanelsAuroraDemo/ChainedPanelsAuroraDemo.ino   | 8 ++++++--
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/examples/AuroraDemo/AuroraDemo.ino b/examples/AuroraDemo/AuroraDemo.ino
index bd07bc3..817780e 100644
--- a/examples/AuroraDemo/AuroraDemo.ino
+++ b/examples/AuroraDemo/AuroraDemo.ino
@@ -16,8 +16,9 @@
 
 /* -------------------------- Display Config Initialisation -------------------- */
 
-#define MATRIX_WIDTH 64
-#define MATRIX_HEIGHT 32
+// MATRIX_WIDTH and MATRIX_HEIGHT *must* be changed in ESP32-HUB75-MatrixPanel-I2S-DMA.h
+// If you are using Platform IO (you should), pass MATRIX_WIDTH and MATRIX_HEIGHT as a compile time option.
+// Refer to: https://github.com/mrfaptastic/ESP32-HUB75-MatrixPanel-I2S-DMA/issues/48#issuecomment-749402379
 
 /* -------------------------- Class Initialisation -------------------------- */
 #include <ESP32-HUB75-MatrixPanel-I2S-DMA.h>
diff --git a/examples/ChainedPanelsAuroraDemo/ChainedPanelsAuroraDemo.ino b/examples/ChainedPanelsAuroraDemo/ChainedPanelsAuroraDemo.ino
index ac23bdf..2800835 100644
--- a/examples/ChainedPanelsAuroraDemo/ChainedPanelsAuroraDemo.ino
+++ b/examples/ChainedPanelsAuroraDemo/ChainedPanelsAuroraDemo.ino
@@ -17,8 +17,12 @@
 
 
 /* -------------------------- Display Config Initialisation -------------------- */
-#define MATRIX_WIDTH 128  // Overall matrix dimensions if laid out end-to-end.
-#define MATRIX_HEIGHT 32
+// MATRIX_WIDTH and MATRIX_HEIGHT *must* be changed in ESP32-HUB75-MatrixPanel-I2S-DMA.h
+// If you are using Platform IO (you should), pass MATRIX_WIDTH and MATRIX_HEIGHT as a compile time option.
+// Refer to: https://github.com/mrfaptastic/ESP32-HUB75-MatrixPanel-I2S-DMA/issues/48#issuecomment-749402379
+
+//This will not work here -> #define MATRIX_WIDTH 128  // Overall matrix dimensions if laid out end-to-end.
+//This will not work here -> #define MATRIX_HEIGHT 32
 
 #define PANEL_RES_X 64 // Number of pixels wide of each INDIVIDUAL panel module. 
 #define PANEL_RES_Y 32 // Number of pixels tall of each INDIVIDUAL panel module.