ScStw/ESP32-HUB75-MatrixPanel-DMA
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Cleanup

Browse source
This commit is contained in:
mrfaptastic 2023-01-21 11:37:28 +00:00
parent ff5d69a4fd
commit 9eacd9a656
2 changed files with 11 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/ESP32-HUB75-MatrixPanel-I2S-DMA.cpp
View file

@ -591,8 +591,10 @@ void MatrixPanel_I2S_DMA::clearFrameBuffer(bool _buff_id){
* @param brt - brightness level from 0 to row_width * @param brt - brightness level from 0 to row_width
* @param _buff_id - buffer id to control * @param _buff_id - buffer id to control
*/ */
void MatrixPanel_I2S_DMA::brtCtrlOE(int brt, const bool _buff_id){
/* /*
// Depreciated
void MatrixPanel_I2S_DMA::brtCtrlOE(int brt, const bool _buff_id){
if (!initialized) if (!initialized)
return; return;
@ -666,9 +668,8 @@ void MatrixPanel_I2S_DMA::brtCtrlOE(int brt, const bool _buff_id){
} while(row_idx); } while(row_idx);
*/
} }
*/
@ -682,21 +683,8 @@ void MatrixPanel_I2S_DMA::brtCtrlOEv2(uint8_t brt, const int _buff_id) {
if (!initialized) if (!initialized)
return; return;
/*
int x_coord_oe_adjust_stop_point = PIXELS_PER_ROW -
if (brt > PIXELS_PER_ROW - (MAX_LAT_BLANKING + 2)) // can't control values larger than (row_width - latch_blanking) to avoid ongoing issues being raised about brightness and ghosting.
brt = PIXELS_PER_ROW - (MAX_LAT_BLANKING + 2); // +2 for a bit of buffer...
if (brt < 0)
brt = 0;
*/
//Serial.println(brightness_in_x_pixels, DEC);
uint8_t _blank = m_cfg.latch_blanking; // don't want to inadvertantly blast over this uint8_t _blank = m_cfg.latch_blanking; // don't want to inadvertantly blast over this
// start with iterating all rows in dma_buff structure // start with iterating all rows in dma_buff structure
int row_idx = dma_buff.rowBits.size(); int row_idx = dma_buff.rowBits.size();
do { do {
@ -745,10 +733,13 @@ void MatrixPanel_I2S_DMA::brtCtrlOEv2(uint8_t brt, const int _buff_id) {
row[ESP32_TX_FIFO_POSITION_ADJUST(x_coord)] |= BIT_OE; // Disable output after this point. row[ESP32_TX_FIFO_POSITION_ADJUST(x_coord)] |= BIT_OE; // Disable output after this point.
} }
// clear OE bit for all other pixels (that is, turn on output)
//row[ESP32_TX_FIFO_POSITION_ADJUST(x_coord)] &= BITMASK_OE_CLEAR; // Note: Old code below from 'brtCtrlOE'
/* /*
// clear OE bit for all other pixels (that is, turn on output)
row[ESP32_TX_FIFO_POSITION_ADJUST(x_coord)] &= BITMASK_OE_CLEAR;
// Brightness control via OE toggle - disable matrix output at specified x_coord // Brightness control via OE toggle - disable matrix output at specified x_coord
if((colouridx > lsbMsbTransitionBit || !colouridx) && ((x_coord) >= brt)){ if((colouridx > lsbMsbTransitionBit || !colouridx) && ((x_coord) >= brt)){

2
src/ESP32-HUB75-MatrixPanel-I2S-DMA.h
View file

@ -718,7 +718,7 @@ class MatrixPanel_I2S_DMA {
* @param brt - brightness level from 0 to row_width * @param brt - brightness level from 0 to row_width
* @param _buff_id - buffer id to control * @param _buff_id - buffer id to control
*/ */
void brtCtrlOE(int brt, const bool _buff_id=0); //void brtCtrlOE(int brt, const bool _buff_id=0);
/** /**
* @brief - reset OE bits in DMA buffer in a way to control brightness * @brief - reset OE bits in DMA buffer in a way to control brightness