From f3302c9f876fa6e9e0dae671311478e2a55324d6 Mon Sep 17 00:00:00 2001 From: mrfaptastic <12006953+mrfaptastic@users.noreply.github.com> Date: Sat, 9 Jan 2021 20:13:42 +0000 Subject: [PATCH] Update ESP32-HUB75-MatrixPanel-I2S-DMA.cpp --- ESP32-HUB75-MatrixPanel-I2S-DMA.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/ESP32-HUB75-MatrixPanel-I2S-DMA.cpp b/ESP32-HUB75-MatrixPanel-I2S-DMA.cpp index 129996c..b84d6f7 100644 --- a/ESP32-HUB75-MatrixPanel-I2S-DMA.cpp +++ b/ESP32-HUB75-MatrixPanel-I2S-DMA.cpp @@ -519,7 +519,12 @@ void MatrixPanel_I2S_DMA::updateMatrixDMABuffer(int16_t x_coord, int16_t y_coord // update address/control bits v &= BITMASK_CTRL_CLEAR; // reset ABCDE,EO,LAT address bits - uint16_t _y = color_depth_idx ? y_coord : y_coord -1; + // normally output current rows ADDX, special case for LSB, output previous row's ADDX (as previous row is being displayed for one latch cycle) + // uint16_t _y = (color_depth_idx == 0) ? + // gpioRowAddress = y_coord-1; + + //uint16_t _y = color_depth_idx ? y_coord : y_coord -1; + uint16_t _y = y_coord; v|=_y << BITS_ADDR_OFFSET; // shift row coord to match ABCDE bits from bit positions 8 to 12 and set bitvector // drive latch while shifting out last bit of RGB data @@ -606,7 +611,8 @@ void MatrixPanel_I2S_DMA::updateMatrixDMABuffer(uint8_t red, uint8_t green, uint } else { // Set ABCDE address bits vector - uint16_t _y = color_depth_idx ? matrix_frame_parallel_row : matrix_frame_parallel_row -1; + //uint16_t _y = color_depth_idx ? matrix_frame_parallel_row : matrix_frame_parallel_row -1; + uint16_t _y = matrix_frame_parallel_row; _y <<= BITS_ADDR_OFFSET; // shift row y-coord to match ABCDE bits in vector from 8 to 12 for(uint16_t x_coord=0; x_coord < MATRIX_WIDTH; x_coord++) {