mirror of
https://github.com/h2zero/esp-nimble-cpp.git
synced 2024-12-22 19:10:46 +01:00
Fix NimBLEHIDDevice output report returning incorrect characteristic. (#805)
The input and output report characteristics share the same UUID and the `getOutputReport` was returning the input report characteristic. This change will return the correct characteristic by finding it with the index parameter.
This commit is contained in:
parent
6357a0dbea
commit
3743eb954e
1 changed files with 3 additions and 1 deletions
|
@ -176,9 +176,11 @@ NimBLECharacteristic* NimBLEHIDDevice::getInputReport(uint8_t reportId) {
|
||||||
* @param [in] reportId Output report ID, the same as in report map for output object related to the characteristic.
|
* @param [in] reportId Output report ID, the same as in report map for output object related to the characteristic.
|
||||||
* @return A pointer to the output report characteristic.
|
* @return A pointer to the output report characteristic.
|
||||||
* @details This will create the characteristic if not already created.
|
* @details This will create the characteristic if not already created.
|
||||||
|
* @note The output report characteristic is optional and should only be created after the input report characteristic.
|
||||||
*/
|
*/
|
||||||
NimBLECharacteristic* NimBLEHIDDevice::getOutputReport(uint8_t reportId) {
|
NimBLECharacteristic* NimBLEHIDDevice::getOutputReport(uint8_t reportId) {
|
||||||
NimBLECharacteristic* outputReportChr = m_hidSvc->getCharacteristic(inputReportChrUuid);
|
// Same uuid as input so this needs to be the second instance
|
||||||
|
NimBLECharacteristic* outputReportChr = m_hidSvc->getCharacteristic(inputReportChrUuid, 1);
|
||||||
if (outputReportChr == nullptr) {
|
if (outputReportChr == nullptr) {
|
||||||
outputReportChr =
|
outputReportChr =
|
||||||
m_hidSvc->createCharacteristic(inputReportChrUuid,
|
m_hidSvc->createCharacteristic(inputReportChrUuid,
|
||||||
|
|
Loading…
Reference in a new issue