From d3aa435448cea4bcd3c08b824b2b4d2f7687eb42 Mon Sep 17 00:00:00 2001 From: h2zero Date: Fri, 21 Aug 2020 20:22:13 -0600 Subject: [PATCH] NimBLEAdvertising: Remove setMin/maxPreferred methods. * These methods were noop's and are now removed due to lack of usefulness and advertisment space consumed if used. Applications can still manually set these values if desired using NimBLEAdvertisementData::addData. --- src/NimBLEAdvertising.cpp | 14 -------------- src/NimBLEAdvertising.h | 2 -- 2 files changed, 16 deletions(-) diff --git a/src/NimBLEAdvertising.cpp b/src/NimBLEAdvertising.cpp index f626cc7..bdf1253 100644 --- a/src/NimBLEAdvertising.cpp +++ b/src/NimBLEAdvertising.cpp @@ -136,20 +136,6 @@ void NimBLEAdvertising::setMaxInterval(uint16_t maxinterval) { } // setMaxInterval -/** - * @brief NOP - Not yet implemented, dummy function for backward compatibility. - */ -void NimBLEAdvertising::setMinPreferred(uint16_t mininterval) { -} // setMinPreferred - - -/** - * @brief NOP - Not yet implemented, dummy function for backward compatibility. - */ -void NimBLEAdvertising::setMaxPreferred(uint16_t maxinterval) { -} // setMaxPreferred - - /** * @brief Set if scan response is available. * @param [in] set true = scan response available. diff --git a/src/NimBLEAdvertising.h b/src/NimBLEAdvertising.h index ed0ffc1..8f8ca17 100644 --- a/src/NimBLEAdvertising.h +++ b/src/NimBLEAdvertising.h @@ -86,8 +86,6 @@ public: void setAdvertisementData(NimBLEAdvertisementData& advertisementData); void setScanFilter(bool scanRequertWhitelistOnly, bool connectWhitelistOnly); void setScanResponseData(NimBLEAdvertisementData& advertisementData); - void setMinPreferred(uint16_t); - void setMaxPreferred(uint16_t); void setScanResponse(bool); private: